Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show issues and PRs without milestones in 'Contributions' preset view #392

Merged
merged 2 commits into from
Jan 21, 2025

Conversation

wx-03
Copy link
Contributor

@wx-03 wx-03 commented Jan 18, 2025

Summary:

Fixes #369

Type of change:

  • 🐛 Bug Fix

Changes Made:

  • Changed 'Contributions' preset view to include issues and PRs without a milestone

Screenshots:

image

Proposed Commit Message:

Include issues/PRs without milestones in 'Contributions' preset view

The 'Contributions' preset view doesn't include issues/PRs without a milestone.

However, issues and PRs without milestones are contributions as well, and should
be included in the 'Contributions' preset view.

Let's show issues and PRs without milestones in the 'Contributions' preset view as well.

Checklist:

  • I have tested my changes thoroughly.
  • I have created tests for any new code files created in this PR or provided a link to a issue/PR that addresses this.
  • I have added or modified code comments to improve code readability where necessary.
  • I have updated the project's documentation as necessary.

Copy link
Contributor

@Arif-Khalid Arif-Khalid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great succinct implementation.
A fantastic PR 😊.
LGTM!

@Arif-Khalid
Copy link
Contributor

Before I merge the PR, could you craft the commit message according to the conventions outlined here
I understand it is a small PR that doesn't necessarily require such a comprehensive format but it would be good to standardize the convention even for small PRs.
You can refer to the commit messages of other closed PRs for inspiration.

@wx-03
Copy link
Contributor Author

wx-03 commented Jan 20, 2025

Before I merge the PR, could you craft the commit message according to the conventions outlined here I understand it is a small PR that doesn't necessarily require such a comprehensive format but it would be good to standardize the convention even for small PRs. You can refer to the commit messages of other closed PRs for inspiration.

@Arif-Khalid Thanks for the review, I've edited the commit message.

@Arif-Khalid Arif-Khalid merged commit a6b925c into CATcher-org:main Jan 21, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Contributions view should include Issues/PRs without milestones
2 participants