-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resample #59
base: master
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## master #59 +/- ##
=========================================
+ Coverage 76.24% 76.65% +0.4%
=========================================
Files 12 12
Lines 1945 1979 +34
=========================================
+ Hits 1483 1517 +34
Misses 462 462
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #59 +/- ##
===========================================
+ Coverage 56.04% 76.65% +20.60%
===========================================
Files 23 12 -11
Lines 4102 1979 -2123
===========================================
- Hits 2299 1517 -782
+ Misses 1803 462 -1341
Continue to review full report at Codecov.
|
Looks good to me. The new skeleton creation is a good approach since it makes adding features like updating the mesh map, etc, purely additive. |
One caveat: it looks to me like it will break if the skeleton is masked such that the root is not in the mask (this is allowed because I have a static skeleton "underneath" the maskable skeleton). I think that's okay to disallow this, but maybe it should be explicitly tested for and rejected. |
This adds a function to resample skeletons (while dropping non root connected components)