add Library Source Material - CDE 14808227 #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grugna
requested review from
hbeale,
melissacline,
kevin-benton,
allisonheath,
jakenoble,
GeoffLyle,
liberaliscomputing,
znatty22,
wnkhan,
mcrusch,
jsunny23,
calkinsh,
Ssandor13 and
leslieduffy
claymcleod
reviewed
Oct 21, 2024
| 4 => LibrarySourceMaterial::SingleNuclei, | ||
| 5 => LibrarySourceMaterial::NotReported, | ||
| 6 => LibrarySourceMaterial::Other, | ||
| _ => LibrarySourceMaterial::Other, |
There was a problem hiding this comment.
This can be 0..6 and just _ to map to Other.
claymcleod
reviewed
Oct 21, 2024
| #[serde(rename = "Bulk-Cells")] | ||
| BulkCells, | ||
|
|
||
| /// `Bulk-Nuclei` |
There was a problem hiding this comment.
This should be Bulk Nuclei (no dash).
claymcleod
reviewed
Oct 21, 2024
| #[serde(rename = "Bulk-Nuclei")] | ||
| BulkNuclei, | ||
|
|
||
| /// `Bulk-Tissue` |
There was a problem hiding this comment.
This should be Bulk Tissue (no dash).
claymcleod
reviewed
Oct 21, 2024
| #[serde(rename = "Single-nuclei")] | ||
| SingleNuclei, | ||
|
|
||
| /// `Not-Reported` |
There was a problem hiding this comment.
This should be Not Reported (no dash).
claymcleod
reviewed
Oct 21, 2024
| /// * **Begin Date**: 03/01/2024 | ||
| /// | ||
| /// Not provided or available. | ||
| #[serde(rename = "Not-Reported")] |
There was a problem hiding this comment.
For all of these, please make sure that the permissible value exactly matches what is in the caDSR field: both for the comment above and for the serde rename.
claymcleod
requested changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Library Source Material entities onto the Sample model.
PR Close Date: [ENTER DATE HERE]
Before submitting this PR, please make sure:
Commits standard.
changes (when appropriate).
CHANGELOG.mdunder[Unreleased].