Address PR comments

CBIIT · Oct 1, 2024 · eee7a8b · eee7a8b
1 parent 63c6e35
commit eee7a8b
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 3 deletions.
diff --git a/src/utils/fetchUtils.ts b/src/utils/fetchUtils.ts
@@ -10,8 +10,9 @@ import { buildReleaseNotesUrl } from "./envUtils";
  * @throws An error if the fetch request fails
  */
 export const fetchReleaseNotes = async (signal?: AbortSignal): Promise<string> => {
-  if (sessionStorage.getItem("releaseNotes")) {
-    return sessionStorage.getItem("releaseNotes");
+  const cachedNotes = sessionStorage.getItem("releaseNotes");
+  if (cachedNotes) {
+    return cachedNotes;
   }
 
   const url: string = buildReleaseNotesUrl();

diff --git a/src/utils/logger.test.ts b/src/utils/logger.test.ts
@@ -62,4 +62,17 @@ describe("Logger", () => {
 
     expect(consoleErrorSpy).not.toHaveBeenCalled();
   });
+
+  it.each<AppEnv["REACT_APP_DEV_TIER"]>(["stage", "prod"])(
+    "should not log on the upper tier '%s'",
+    (tier) => {
+      env.NODE_ENV = "development"; // Override 'test' to log the message
+
+      env.REACT_APP_DEV_TIER = tier;
+
+      Logger.error("A message that should not be visible");
+
+      expect(consoleErrorSpy).not.toHaveBeenCalled();
+    }
+  );
 });
diff --git a/src/utils/logger.ts b/src/utils/logger.ts
@@ -17,11 +17,16 @@ export type LogLevel = "error";
  * @returns void
  */
 const LoggingWrapper = (level: LogLevel, message: string, ...optionalParams: unknown[]): void => {
-  // Skip logging in a test environment.
+  // Skip logging in a testing context.
   if (env?.NODE_ENV === "test") {
     return;
   }
 
+  // Skip logging on stage or production environments.
+  if (env?.REACT_APP_DEV_TIER === "prod" || env?.REACT_APP_DEV_TIER === "stage") {
+    return;
+  }
+
   const timestamp = new Date().toISOString();
   switch (level) {
     case "error":