Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CRDCDH-602 Uploader CLI Dialog #211

Merged
merged 3 commits into from
Nov 22, 2023
Merged

CRDCDH-602 Uploader CLI Dialog #211

merged 3 commits into from
Nov 22, 2023

Conversation

amattu2
Copy link
Member

@amattu2 amattu2 commented Nov 15, 2023 •
edited
Loading

Overview

This adds a dialog for the Uploader CLI download links.

Change Details (Specifics)

  • Based off of the API Token dialog per K.C.
  • Currently it just provides the GitHub link to the repo

Related Ticket(s)

https://tracker.nci.nih.gov/browse/CRDCDH-602

@amattu2 amattu2 added the 🚧 Do Not Merge This PR is not ready for merging label Nov 15, 2023
@amattu2 amattu2 added this to the MVP-2.0.0 (M2) milestone Nov 15, 2023
@amattu2 amattu2 marked this pull request as ready for review November 16, 2023 19:34
@amattu2 amattu2 removed the 🚧 Do Not Merge This PR is not ready for merging label Nov 22, 2023
Alejandro-Vega
Alejandro-Vega approved these changes Nov 22, 2023
View reviewed changes
Copy link
Collaborator

@Alejandro-Vega Alejandro-Vega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Alejandro-Vega Alejandro-Vega merged commit 3b1fbb9 into mvp-2 Nov 22, 2023
1 check passed
@Alejandro-Vega Alejandro-Vega deleted the amattu2/CRDCDH-602 branch November 22, 2023 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alejandro-Vega Alejandro-Vega Alejandro-Vega approved these changes

@mtangmt mtangmt Awaiting requested review from mtangmt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0.0 (MVP2-M2)
Development

Successfully merging this pull request may close these issues.
2 participants
@amattu2 @Alejandro-Vega