CRDCDH-496 Batch Table Error Count #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amattu2
requested changes
Dec 15, 2023
There was a problem hiding this comment.
Added two questions about differences between the CRDCDH-496 user story and the implementation. One potential (optional) improvement suggested. Functionally it work as expected.
Tested in submission 2d563b5d-0560-401b-aaa4-551cf52721af with manually added errors.
amattu2
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR aims to add an Error dialog to the Batch table to display errors that occur during essential validation service.
Change Details (Specifics)
NOTE: Currently validation engine is not done, so no errors will be generated
Related Ticket(s)
CRDCDH-496