Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRDCDH-680 Remove ICDC #248

Merged
merged 2 commits into from
Dec 26, 2023
Merged

CRDCDH-680 Remove ICDC #248

merged 2 commits into from
Dec 26, 2023

Conversation

amattu2
Copy link
Member

@amattu2 amattu2 commented Dec 20, 2023

Overview

Per changing requirements, this PR removes the ICDC model from the DH FE.

Change Details (Specifics)

N/A

Related Ticket(s)

CRDCDH-680

Important

This is a fix for M2 only, and should not be merged into the M3 release branch yet.

Also will be removed from our models repo
@amattu2 amattu2 added the 🚧 Do Not Merge This PR is not ready for merging label Dec 20, 2023
@amattu2 amattu2 added this to the MVP-2.0.0 (M2) milestone Dec 21, 2023
@amattu2 amattu2 removed the 🚧 Do Not Merge This PR is not ready for merging label Dec 21, 2023
@amattu2 amattu2 marked this pull request as ready for review December 21, 2023 20:04
Copy link
Collaborator

@Alejandro-Vega Alejandro-Vega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Alejandro-Vega Alejandro-Vega merged commit 617c077 into mvp-2 Dec 26, 2023
1 check passed
@Alejandro-Vega Alejandro-Vega deleted the CRDCDH-680 branch December 26, 2023 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants