Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRDCDH-659 Poll for file validation status #249

Merged
merged 5 commits into from
Dec 26, 2023
Merged

Conversation

amattu2
Copy link
Member

@amattu2 amattu2 commented Dec 20, 2023

Overview

This PR introduces data submission polling to track the file validation status.

Tip

The validation API works, but no validation happens yet; thus you will need to manually update the data submission object to change metadataValidationStatus (sp.) or fileValidationStatus (sp) from "Validating" to another state in order to see the button re-enable.

Change Details (Specifics)

  • Removed the usage of states for the Data Submission and Stats so that we can use native Apollo polling directly
  • Migrated from useLazyQuery to useQuery for GET_SUBMISSION query
    • This will auto fetch the submission on component mount so that we don't need to manually initiate it
  • Fixed a 508 issue with an empty button when there are no batch errors
  • Fixed GenericAlert hiding under the Navbar Dropdown container (had equal z-index)
Screenshot 2023-12-22 at 9 35 43 AM

Related Ticket(s)

CRDCDH-659

Important

This ticket can be merged, but needs to go back to On Hold while we wait for the validation service.

@amattu2 amattu2 added this to the MVP-2.1.0 (M3) milestone Dec 20, 2023
@amattu2 amattu2 marked this pull request as ready for review December 21, 2023 15:18
Copy link
Collaborator

@Alejandro-Vega Alejandro-Vega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Alejandro-Vega Alejandro-Vega merged commit 9258c9b into mvp-2.1.0 Dec 26, 2023
1 check passed
@Alejandro-Vega Alejandro-Vega deleted the CRDCDH-659 branch December 26, 2023 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants