Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRDCDH-594 Submit Using Validation Status #253

Closed
wants to merge 6 commits into from

Conversation

Alejandro-Vega
Copy link
Collaborator

@Alejandro-Vega Alejandro-Vega commented Jan 2, 2024

Overview

This PR aims to use metadataValidationStatus and fileValidationStatus properties from the submission, instead of the stat nodes, to decide whether or not to disable the submit button. This is so that the FE and BE are both on the same page.

Change Details (Specifics)

N/A

Related Ticket(s)

CRDCDH-594
CRDCDH-635

@Alejandro-Vega Alejandro-Vega added this to the MVP-2.1.0 (M3) milestone Jan 2, 2024
@Alejandro-Vega Alejandro-Vega marked this pull request as ready for review January 4, 2024 14:33
@Alejandro-Vega Alejandro-Vega added the 🚧 Do Not Merge This PR is not ready for merging label Jan 4, 2024
@Alejandro-Vega Alejandro-Vega removed the 🚧 Do Not Merge This PR is not ready for merging label Jan 9, 2024
Copy link
Member

@amattu2 amattu2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This logic seems to incorrectly allow for submission in these scenario(s):

metadataValidationStatus fileValidationStatus
null Passed
null null

My understanding is that, at a minimum, all submissions need metadata? It may not be possible for this scenario to occur in a real submission, but I would recommend we cover for it.


Other scenarios tested and working as expected:

metadataValidationStatus fileValidationStatus
Passed null
Warning null
Passed Passed
Passed Warning
Warning Passed

@amattu2 amattu2 mentioned this pull request Jan 9, 2024
@Alejandro-Vega
Copy link
Collaborator Author

Alejandro-Vega commented Jan 9, 2024

This logic seems to incorrectly allow for submission in these scenario(s):

metadataValidationStatus fileValidationStatus
null Passed
null null
My understanding is that, at a minimum, all submissions need metadata? It may not be possible for this scenario to occur in a real submission, but I would recommend we cover for it.

Other scenarios tested and working as expected:

metadataValidationStatus fileValidationStatus
Passed null
Warning null
Passed Passed
Passed Warning
Warning Passed

Updated to disable submit if metadataValidationStatus is null. Also added refresh for submission when an upload occurs, because the validation statuses get updated.

@Alejandro-Vega Alejandro-Vega added 🚧 Do Not Merge This PR is not ready for merging and removed 🚧 Do Not Merge This PR is not ready for merging labels Jan 9, 2024
@amattu2 amattu2 deleted the CRDCDH-594-validation-status branch February 22, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚧 Do Not Merge This PR is not ready for merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants