-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CRDCDH-753 Data Submission Improvements #265
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Initial review looks good. Only one potential issue and one suggestion for the QC rebrand.
PR can't be fully verified until validation is working again.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Will merge after we can run validation again.
Overview
This PR aims to make updates to the Data Submission Dashboard.
Change Details (Specifics)
Data Upload Tab:
QC Tab:
QC Error Dialog
Related Ticket(s)
CRDCDH-753 (NOTE: Can't confirm Validation Type column is functioning properly until validation starts working again)
CRDCDH-552
CRDCDH-682
CRDCDH-777 (Bug Ticket. Things are broken due to API changing)
NOTE: Tickets were combined in this PR due to API changes breaking things from each. I combined them to have a single working PR, rather than separate broken PR's