Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRDCDH-753 Data Submission Improvements #265

Merged
merged 12 commits into from
Jan 23, 2024
Merged

CRDCDH-753 Data Submission Improvements #265

merged 12 commits into from
Jan 23, 2024

Conversation

Alejandro-Vega
Copy link
Collaborator

@Alejandro-Vega Alejandro-Vega commented Jan 19, 2024

Overview

This PR aims to make updates to the Data Submission Dashboard.

Change Details (Specifics)

Data Upload Tab:

  • Rename column "Errors" to "Upload Errors"

QC Tab:

  • Rename tab to "Validation Results"
  • Renamed column "Type" to "Node Type"
  • Renamed column "Reasons" to "Issues"
  • Added column "Validation Type".
  • Replaced column "Updated Date" with "Validated Date" (Different properties)
  • Updated default sorting to Batch ID in desc order
  • Confirmed Node Type property is secondary key in ascending order (BE supporting this automatically)

QC Error Dialog

  • Updated wording
  • Removed header and date
  • Listed issues with errors displaying at the top and warnings displaying after

Related Ticket(s)

CRDCDH-753 (NOTE: Can't confirm Validation Type column is functioning properly until validation starts working again)
CRDCDH-552
CRDCDH-682
CRDCDH-777 (Bug Ticket. Things are broken due to API changing)

NOTE: Tickets were combined in this PR due to API changes breaking things from each. I combined them to have a single working PR, rather than separate broken PR's

@Alejandro-Vega Alejandro-Vega added this to the MVP-2.1.0 (M3) milestone Jan 19, 2024
@Alejandro-Vega Alejandro-Vega marked this pull request as ready for review January 22, 2024 14:26
Copy link
Member

@amattu2 amattu2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initial review looks good. Only one potential issue and one suggestion for the QC rebrand.

PR can't be fully verified until validation is working again.

src/content/dataSubmissions/QualityControl.tsx Outdated Show resolved Hide resolved
Copy link
Member

@amattu2 amattu2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Will merge after we can run validation again.

@amattu2 amattu2 merged commit c5d8a71 into mvp-2.1.0 Jan 23, 2024
1 check passed
@amattu2 amattu2 deleted the CRDCDH-753 branch January 23, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants