Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRDCDH-668 Batch File List "No Content" message update #266

Merged
merged 2 commits into from
Jan 22, 2024

Conversation

amattu2
Copy link
Member

@amattu2 amattu2 commented Jan 22, 2024

Overview

This PR slightly modifies the FE implementation of the Batch File List by changing the table's no-content message to conform to the user story.

Note

To test this, use the uploader CLI and upload a set of files twice with the config option overwrite set to false.
Or you can use the DEV submission 3e568f16-f135-47e2-ba69-87d0f707bc01

Change Details (Specifics)

  • Update the UploadResult type definition to include the skipped property
  • Add a numRowsNoContent prop to the generic table
  • Replace the default no-content message with the one from the user story

Related Ticket(s)

CRDCDH-668

@amattu2 amattu2 added this to the MVP-2.1.0 (M3) milestone Jan 22, 2024
@amattu2 amattu2 changed the title CRDCDH-668 Show no files message instead of table CRDCDH-668 Batch File List "No Content" message update Jan 22, 2024
Copy link
Collaborator

@Alejandro-Vega Alejandro-Vega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Alejandro-Vega Alejandro-Vega merged commit f38fc6c into mvp-2.1.0 Jan 22, 2024
1 check passed
@Alejandro-Vega Alejandro-Vega deleted the CRDCDH-668 branch January 22, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants