Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Study removal prompt persisting past first save #268

Merged
merged 3 commits into from
Jan 23, 2024

Conversation

amattu2
Copy link
Member

@amattu2 amattu2 commented Jan 22, 2024

Overview

This PR fixes an issue with the "Active Data Submission" confirmation dialog appearing any time the organization is saved, even after removing the original study that caused the prompt.

Change Details (Specifics)

  • Migrate successful organization save/create GenericAlert to Notistack
  • Update organization state after saving changes

Related Ticket(s)

CRDCDH-689

Also migrates to Notistack for this specific page
@amattu2 amattu2 added this to the MVP-2.1.0 (M3) milestone Jan 22, 2024
@amattu2 amattu2 changed the title fix: Active submission prompt persisting past first save fix: Study removal prompt persisting past first save Jan 22, 2024
@amattu2 amattu2 marked this pull request as ready for review January 22, 2024 17:24
Copy link
Collaborator

@Alejandro-Vega Alejandro-Vega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Alejandro-Vega Alejandro-Vega merged commit f9ac8e8 into mvp-2.1.0 Jan 23, 2024
1 check passed
@Alejandro-Vega Alejandro-Vega deleted the CRDCDH-689-Fix branch January 23, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants