Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CRDCDH-715 Admin Submit justification, CRDCDH-728 Updates #274

Merged
merged 4 commits into from
Feb 1, 2024
Merged

CRDCDH-715 Admin Submit justification, CRDCDH-728 Updates #274

merged 4 commits into from
Feb 1, 2024

Conversation

amattu2
Copy link
Member

@amattu2 amattu2 commented Jan 30, 2024 •
edited
Loading

Overview

This PR builds off CRDCDH-728 by requiring a comment when performing an administrative submit of a Data Submission.

Change Details (Specifics)

  • Add a Admin Submit dialog that's enabled only when the Submit Button label is "Admin Submit"
  • Clear review comment text anytime the dialog is closed (cancel or submit actions)
  • Update CRDCDH-728 for latest requirements (comment placeholder)

Related Ticket(s)

CRDCDH-715
CRDCDH-728

@amattu2 amattu2 added this to the MVP-2.1.0 (M3) milestone Jan 30, 2024
@amattu2 amattu2 added the 🚧 Do Not Merge This PR is not ready for merging label Jan 30, 2024
@amattu2 amattu2 marked this pull request as draft January 31, 2024 15:03
@amattu2 amattu2 removed the 🚧 Do Not Merge This PR is not ready for merging label Feb 1, 2024
@amattu2 amattu2 changed the title CRDCDH-715 Admin Submit justification CRDCDH-715 Admin Submit justification, CRDCDH-728 Updates Feb 1, 2024
@amattu2 amattu2 marked this pull request as ready for review February 1, 2024 16:38
Alejandro-Vega
Alejandro-Vega approved these changes Feb 1, 2024
View reviewed changes
Copy link
Collaborator

@Alejandro-Vega Alejandro-Vega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@Alejandro-Vega Alejandro-Vega merged commit 35fd63b into mvp-2.1.0 Feb 1, 2024
1 check passed
@Alejandro-Vega Alejandro-Vega deleted the CRDCDH-715 branch February 1, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alejandro-Vega Alejandro-Vega Alejandro-Vega approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.1.0 (MVP2-M3)
Development

Successfully merging this pull request may close these issues.
2 participants
@amattu2 @Alejandro-Vega