Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRDCDH-538 Validation Statistics Design #4 #280

Merged
merged 13 commits into from
Feb 22, 2024
Merged

Conversation

amattu2
Copy link
Member

@amattu2 amattu2 commented Feb 12, 2024

Overview

This PR converts the implementation of Data Submission Statistics to Design 4.

Change Details (Specifics)

  • Change primary chart to a bar chart w/View by Count or Percentage (i.e. normalized data or not)
  • Add custom tooltip for primary chart
  • Add "Validation Status" text to legend and update LegendItem text color
  • Move primary label to centered above the chart
  • Migrate statistic type definitions to a independent type file
  • Fix utility index.ts file not exporting the statisticUtils
  • Potential fix for "Total 0" placeholder randomly disappearing
    • The fix assumes that it's impossible for a hoveredSlice to have a value of 0 because slices with a value zero don't appear in the chart
  • Remove carousel infinite scroll (ba01a0e)

Related Ticket(s)

CRDCDH-538

@amattu2 amattu2 added this to the MVP-2.1.0 (M3) milestone Feb 12, 2024
@amattu2 amattu2 marked this pull request as draft February 12, 2024 18:27
@amattu2 amattu2 marked this pull request as ready for review February 21, 2024 14:07
Copy link
Collaborator

@Alejandro-Vega Alejandro-Vega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I just left some small comments on design changes and some optional ones.

src/components/NodeTotalChart/CustomTick.tsx Show resolved Hide resolved
src/components/NodeTotalChart/index.tsx Show resolved Hide resolved
src/components/Carousel/index.tsx Show resolved Hide resolved
src/components/NodeTotalChart/Tooltip.tsx Show resolved Hide resolved
@Alejandro-Vega Alejandro-Vega merged commit 6b98db6 into mvp-2.1.0 Feb 22, 2024
1 check passed
@Alejandro-Vega Alejandro-Vega deleted the CRDCDH-538-D4 branch February 22, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants