Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRDCDH-538 Fix Node Sorting & Partially-Visible Carousel Elements #288

Merged
merged 4 commits into from
Feb 28, 2024

Conversation

amattu2
Copy link
Member

@amattu2 amattu2 commented Feb 23, 2024

Overview

This is a minor change to the CRDCDH-538 implementation to fix an issue noticed in the prod builds.

Issue 1: Inconsistent Node Sorting

Without React StrictMode, the nodes in the primary chart would appear in the order that the API sent the nodes until you switch the view type.

Screenshot 2024-02-23 at 9 35 24 AM Screenshot 2024-02-23 at 9 36 02 AM
Issue 2: Partially Visible Nodes

For small datasets (under 3 nodes), the carousel would partially overlap with the individual node charts and not provide arrows to make them visible. This is fixed now.

Cases:

Change Details (Specifics)

  • Sort the dataset at the component level, prior to the primary chart rendering
  • Recenter the carousel track (previously removed)
  • Conditionally add the PaddingBox element to the carousel children
  • Replace "no data..." message to conform to the user story

Related Ticket(s)

CRDCDH-538

@amattu2 amattu2 added this to the MVP-2.1.0 (M3) milestone Feb 23, 2024
@amattu2 amattu2 marked this pull request as ready for review February 23, 2024 14:33
@amattu2 amattu2 added the 🚧 Do Not Merge This PR is not ready for merging label Feb 23, 2024
@amattu2 amattu2 removed the 🚧 Do Not Merge This PR is not ready for merging label Feb 26, 2024
@amattu2 amattu2 changed the title CRDCDH-538 Fix Bar chart order changing arbitrarily CRDCDH-538 Fix Node Sorting & Partially-Visible Carousel Elements Feb 26, 2024
Copy link
Collaborator

@Alejandro-Vega Alejandro-Vega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Alejandro-Vega Alejandro-Vega merged commit e9322f4 into mvp-2.1.0 Feb 28, 2024
1 check passed
@Alejandro-Vega Alejandro-Vega deleted the CRDCDH-538-Hotfix branch February 28, 2024 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants