Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRDCDH-860 Optional Study Abbreviation #301

Merged
merged 8 commits into from
Mar 15, 2024
Merged

Conversation

amattu2
Copy link
Member

@amattu2 amattu2 commented Mar 11, 2024

Overview

This PR modifies the Submission Request Questionnaire > Section B > Study Abbreviation implementation to remove the required and unique constraints.

A majority of the changes are handled in the backend – if no abbreviation is provided, the study name will be populated in place of the abbreviation property. Additionally, per current requirements, we don't need to maintain a unique reference to the original ApprovedStudy object, so none of the models (Organization, Data Submission, ...) are being updated to include the _id property.

Change Details (Specifics)

  • Within the Submission Request saveApplication API, if no Study Abbreviation is provided, the Study Name is used instead
  • Migrate the organization's study tooltip to a separate file
  • Refactor the Organization Edit page to rely on the Study _id when possible instead of the non-unique study abbreviation

Related Ticket(s)

CRDCDH-860

@amattu2 amattu2 added this to the MVP-2.1.0 (M3) milestone Mar 11, 2024
@amattu2 amattu2 changed the title CRDCDH-860 CRDCDH-860 Optional Study Abbreviation Mar 11, 2024
@amattu2 amattu2 marked this pull request as ready for review March 13, 2024 13:49
Copy link
Collaborator

@Alejandro-Vega Alejandro-Vega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Alejandro-Vega Alejandro-Vega merged commit 26fd8d6 into mvp-2.1.0 Mar 15, 2024
2 checks passed
@Alejandro-Vega Alejandro-Vega deleted the CRDCDH-860 branch March 15, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants