Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRDCDH-1160 Organization dropdown sorting #396

Merged
merged 16 commits into from
Jun 17, 2024
Merged

CRDCDH-1160 Organization dropdown sorting #396

merged 16 commits into from
Jun 17, 2024

Conversation

Alejandro-Vega
Copy link
Collaborator

@Alejandro-Vega Alejandro-Vega commented Jun 6, 2024

Overview

Updated the organizations dropdown be sorted by name alphabetically in ascending order. Pages affected should be Manage Users/Edit User page as well as Data Submission List page.

Change Details (Specifics)

  • Updated the organizations in OrganizationsListContext to be sorted by name alphabetically in ascending order
  • Added tests for the OrganizationsListContext
  • Updated Data Submission List organization dropdown to use OrganizationsListContext instead and filtered out inactive organizations
  • Updated organizations input to display an inactive organization only if the user belongs to that organization. Previously, it would just show a blank value in the input
  • After switching a user from an inactive organization, it should no longer display the inactive organization in the dropdown

Related Ticket(s)

CRDCDH-1160

@Alejandro-Vega Alejandro-Vega added this to the 3.0.0 (PMVP-M1) milestone Jun 6, 2024
@coveralls

This comment was marked as outdated.

@coveralls

This comment was marked as outdated.

@coveralls

This comment was marked as outdated.

Copy link
Member

@amattu2 amattu2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jest is reporting some Apollo and React issues with the tests, could you take a look? I'm not sure why it didn't fail the Jest action.

All of the actual changes LGTM and thanks for adding test coverage!

src/components/Contexts/OrganizationListContext.test.tsx Outdated Show resolved Hide resolved
src/components/Contexts/OrganizationListContext.test.tsx Outdated Show resolved Hide resolved
@coveralls

This comment was marked as outdated.

@Alejandro-Vega Alejandro-Vega added the 🚧 Do Not Merge This PR is not ready for merging label Jun 7, 2024
@coveralls

This comment was marked as outdated.

@coveralls
Copy link
Collaborator

coveralls commented Jun 17, 2024

Pull Request Test Coverage Report for Build 9552400848

Details

  • 8 of 29 (27.59%) changed or added relevant lines in 5 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.4%) to 31.563%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/content/users/ListView.tsx 0 1 0.0%
src/content/dataSubmissions/Controller.tsx 0 2 0.0%
src/content/dataSubmissions/DataSubmissionsListView.tsx 0 3 0.0%
src/content/users/ProfileView.tsx 0 15 0.0%
Files with Coverage Reduction New Missed Lines %
src/content/users/ProfileView.tsx 2 0.0%
Totals Coverage Status
Change from base Build 9548943433: 0.4%
Covered Lines: 1630
Relevant Lines: 4420

💛 - Coveralls

@Alejandro-Vega Alejandro-Vega removed the 🚧 Do Not Merge This PR is not ready for merging label Jun 17, 2024
Copy link
Member

@amattu2 amattu2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything LGTM!

@amattu2 amattu2 merged commit d0aa804 into 3.0.0 Jun 17, 2024
6 checks passed
@amattu2 amattu2 deleted the CRDCDH-1160 branch June 17, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants