Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRDCDH-1774 Ignore casing when comparing name/abbr #492

Merged
merged 2 commits into from
Oct 11, 2024
Merged

Conversation

amattu2
Copy link
Member

@amattu2 amattu2 commented Oct 11, 2024

Overview

Simple bug fix to address the formatFullStudyName not ignoring casing when comparing the equality of the Study Name and Study Abbreviation.

Change Details (Specifics)

  • Force study name and abbreviation to lowercase before comparing equality
  • Update test coverage to test for this bug

Related Ticket(s)

CRDCDH-1774

@amattu2 amattu2 added this to the 3.1.0 (PMVP-M2) milestone Oct 11, 2024
@amattu2 amattu2 marked this pull request as ready for review October 11, 2024 17:43
Copy link
Collaborator

@Alejandro-Vega Alejandro-Vega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Didn't test

@Alejandro-Vega Alejandro-Vega added the Not Run This PR was not tested locally label Oct 11, 2024
@Alejandro-Vega Alejandro-Vega merged commit c7d44b5 into 3.1.0 Oct 11, 2024
5 checks passed
@Alejandro-Vega Alejandro-Vega deleted the CRDCDH-1774 branch October 11, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Not Run This PR was not tested locally
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants