Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRDCDH-1674 Update Submit button logic for Admin Submit #494

Merged
merged 3 commits into from
Oct 15, 2024
Merged

Conversation

Alejandro-Vega
Copy link
Collaborator

Overview

Removed Admin Override option for when missing either "Metadata" or "Data Files" within a "Metadata and Data Files" Data Submission.

Change Details (Specifics)

  • Removed Admin Override rule
  • Updated some basic rules to be required to avoid it being overridable
  • Updated tests to reflect change

Related Ticket(s)

CRDCDH-1674 (Bug Ticket)

@Alejandro-Vega Alejandro-Vega added this to the 3.1.0 (PMVP-M2) milestone Oct 11, 2024
@Alejandro-Vega Alejandro-Vega marked this pull request as ready for review October 11, 2024 20:49
@amattu2 amattu2 added the Not Run This PR was not tested locally label Oct 15, 2024
Copy link
Member

@amattu2 amattu2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't test locally, but code change LGTM!

@amattu2 amattu2 merged commit d0431eb into 3.1.0 Oct 15, 2024
5 checks passed
@amattu2 amattu2 deleted the CRDCDH-1674 branch October 15, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Not Run This PR was not tested locally
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants