Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CRDCDH-1497 #496

Merged
merged 3 commits into from
Oct 18, 2024
Merged

CRDCDH-1497 #496

merged 3 commits into from
Oct 18, 2024

Conversation

ty-esi
Copy link
Collaborator

@ty-esi ty-esi commented Oct 15, 2024

Overview

Data Model Navigator improvements to support CDEs.

Change Details (Specifics)

  • refactored updateEnums to add CDE info (fullName, version, etc) to the dictionary object for each property.
  • updated menu names under available downloads.

Related Ticket(s)

https://tracker.nci.nih.gov/browse/CRDCDH-1497

@ty-esi ty-esi added this to the 3.1.0 (PMVP-M2) milestone Oct 15, 2024
@ty-esi ty-esi requested a review from amattu2 October 15, 2024 16:21
@ty-esi ty-esi changed the base branch from main to 3.1.0 October 15, 2024 16:33
amattu2
amattu2 approved these changes Oct 18, 2024
View reviewed changes
Copy link
Member

@amattu2 amattu2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both FE and DMN changes LGTM. I updated the package in commit dbf24af and also added a missing attribute so the links build.

Nice work!

@amattu2 amattu2 disabled auto-merge October 18, 2024 13:31
@amattu2 amattu2 merged commit 8b1df14 into 3.1.0 Oct 18, 2024
5 checks passed
@amattu2 amattu2 deleted the CRDCDH-1497 branch October 18, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amattu2 amattu2 amattu2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.1.0 (PMVP-M2)
Development

Successfully merging this pull request may close these issues.
2 participants
@ty-esi @amattu2