Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CRDCDH-1411 Add collaborators to Data Submission Summary section #497

Merged
merged 12 commits into from
Oct 16, 2024
Merged

CRDCDH-1411 Add collaborators to Data Submission Summary section #497

merged 12 commits into from
Oct 16, 2024

Conversation

Alejandro-Vega
Copy link
Collaborator

@Alejandro-Vega Alejandro-Vega commented Oct 15, 2024 •
edited
Loading

Overview

Updated the Data Submission Summary section to match new design and structure. Also added new collaborators property.

Change Details (Specifics)

  • Updated getSubmission query to return collaborators, and updated types
  • Updated baseSubmission for existing tests
  • Added truncated values for each property in the summary section, except for "Submission Type", "Data Commons", and "Collaborators" as these are mostly fixed and unlikely to get really long
  • Added collaborators property with a link appearance, and a tooltip on hover. In a future PR, this will open a dialog to manage collaborators, for now it does nothing
  • Updated spacing and styling for entire summary section

Note

For a submission with a collaborator, I created one manually via the DB.
The submission ID is: 01858c9d-17d8-4980-b3a5-0e9d47b5acf5

Related Ticket(s)

CRDCDH-1647 (Task)
CRDCDH-1411 (User Story)

@Alejandro-Vega Alejandro-Vega added this to the 3.1.0 (PMVP-M2) milestone Oct 15, 2024
@Alejandro-Vega Alejandro-Vega added the 🚧 Do Not Merge This PR is not ready for merging label Oct 15, 2024
@Alejandro-Vega Alejandro-Vega removed the 🚧 Do Not Merge This PR is not ready for merging label Oct 15, 2024
@Alejandro-Vega Alejandro-Vega marked this pull request as ready for review October 15, 2024 21:07
amattu2
amattu2 requested changes Oct 16, 2024
View reviewed changes
Copy link
Member

@amattu2 amattu2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! Just a few comments/suggestions annotated.

src/components/DataSubmissions/SubmissionHeaderProperty.tsx Outdated Show resolved Hide resolved
src/graphql/getSubmission.ts Outdated Show resolved Hide resolved
src/components/DataSubmissions/DataSubmissionSummary.tsx Outdated Show resolved Hide resolved
src/components/DataSubmissions/DataSubmissionSummary.test.tsx Show resolved Hide resolved
@amattu2 amattu2 added the 📝 Change Requested This PR has requested changes label Oct 16, 2024
@Alejandro-Vega Alejandro-Vega removed the 📝 Change Requested This PR has requested changes label Oct 16, 2024
amattu2
amattu2 approved these changes Oct 16, 2024
View reviewed changes
Copy link
Member

@amattu2 amattu2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM!

@amattu2 amattu2 merged commit 658acc3 into 3.1.0 Oct 16, 2024
5 checks passed
@amattu2 amattu2 deleted the CRDCDH-1411 branch October 16, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amattu2 amattu2 amattu2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.1.0 (PMVP-M2)
Development

Successfully merging this pull request may close these issues.
2 participants
@Alejandro-Vega @amattu2