Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move shared functions to ccbr_tools and import them here #32

Merged
merged 10 commits into from
Sep 13, 2024

Conversation

kelly-sovacool
Copy link
Member

@kelly-sovacool kelly-sovacool commented Aug 16, 2024

Changes

Import reusable helper functions from ccbr_tools

Issues

resolves #31

PR Checklist

(Strikethrough any points that are not applicable.)

  • This comment contains a description of changes with justifications, with any relevant issues linked.
  • Write unit tests for any new features, bug fixes, or other code changes.
  • [ ] Update docs if there are any API changes.
  • [ ] If a new nextflow process is implemented, define the process container and stub.
  • [ ] Update CHANGELOG.md with a short description of any user-facing changes and reference the PR number. Guidelines: https://keepachangelog.com/en/1.1.0/

@kelly-sovacool kelly-sovacool self-assigned this Aug 16, 2024
@kelly-sovacool kelly-sovacool marked this pull request as ready for review August 19, 2024 19:12
Copy link
Member

@kopardev kopardev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a tacit dependency here on ccbrpipeliner/7 which will load the latest ccbr_tools which will have the tools needed?

@kelly-sovacool
Copy link
Member Author

is there a tacit dependency here on ccbrpipeliner/7 which will load the latest ccbr_tools which will have the tools needed?

yes, this design means we assume our biowulf users will access the pipeline CLIs by loading ccbrpipeliner/7+

if it is installed via pip (ie if someone wanted to install outside of biowulf), ccbr_tools will also be installed because it's a dependency (https://github.com/CCBR/CCBR_NextflowTemplate/pull/32/files#diff-50c86b7ed8ac2cf95bd48334961bf0530cdc77b5a56f852c5c61b89d735fd711R36)

@kelly-sovacool kelly-sovacool marked this pull request as draft September 12, 2024 21:10
@kelly-sovacool kelly-sovacool added this to the 2024-09 milestone Sep 13, 2024
@kelly-sovacool kelly-sovacool marked this pull request as ready for review September 13, 2024 14:29
@kelly-sovacool kelly-sovacool merged commit 2937e1f into main Sep 13, 2024
2 checks passed
@kelly-sovacool kelly-sovacool deleted the use-tools branch September 13, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

use shared utility functions from CCBR/Tools
2 participants