-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: move shared functions to ccbr_tools and import them here #32
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there a tacit dependency here on ccbrpipeliner/7 which will load the latest ccbr_tools which will have the tools needed?
yes, this design means we assume our biowulf users will access the pipeline CLIs by loading ccbrpipeliner/7+ if it is installed via pip (ie if someone wanted to install outside of biowulf), ccbr_tools will also be installed because it's a dependency (https://github.com/CCBR/CCBR_NextflowTemplate/pull/32/files#diff-50c86b7ed8ac2cf95bd48334961bf0530cdc77b5a56f852c5c61b89d735fd711R36) |
Changes
Import reusable helper functions from ccbr_tools
Issues
resolves #31
PR Checklist
(
Strikethroughany points that are not applicable.)[ ] Update docs if there are any API changes.[ ] If a new nextflow process is implemented, define the processcontainer
andstub
.[ ] UpdateCHANGELOG.md
with a short description of any user-facing changes and reference the PR number. Guidelines: https://keepachangelog.com/en/1.1.0/