-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug fix related to correct default targets file in GUI #109
Conversation
Lines 373 to 379 in dd7509e
Instead of hardcoding targets with an if-else statement in the GUI logic, can you allow GUI users to pass an empty string through |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@samarth8392 See comment below and let me know!
Thanks @kelly-sovacool , the updated code works as expected. I have pushed the changes. Ready for final review. |
@samarth8392 Looks good, thanks for fixing this! |
Changes
Updated
gui.py
to include another if-else statement to choose the correct default targets file based on the genome selected.Issues
Resolves #108
PR Checklist
(
Strikethroughany points that are not applicable.)- [ ] Update docs if there are any API changes.CHANGELOG.md
with a short description of any user-facing changes and reference the PR number. Guidelines: https://keepachangelog.com/en/1.1.0/