Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade README.md to have some more instructions #97

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Yusuto
Copy link

@Yusuto Yusuto commented May 1, 2022

Update README.md to have a bit more information on installing CCLoader and mods (someone asked on Discord last night).

Update README.md to have a bit more information on installing CCLoader and mods (someone asked on Discord last night).
@lexisother
Copy link
Member

Just for reference, might be a useful resource: https://wiki.c2dl.info/CCLoader

@Yusuto
Copy link
Author

Yusuto commented May 1, 2022

Just for reference, might be a useful resource: https://wiki.c2dl.info/CCLoader

Oh, Thank you!
I know that one, I disregarded the automatic installer from the README for now, although it probably warrants a mention?

@lexisother
Copy link
Member

lexisother commented May 1, 2022

I'll be honest, I haven't the slightest clue of, well, if it still works. It's a rather old project, and I can't remember the last time somebody used it.

It probably still works, but it's just that nobody knows about it.
A mention may be warranted.

@Yusuto
Copy link
Author

Yusuto commented May 1, 2022

Yep, maybe a 'lil cleaning u, it seems quite hacked together (I saw a few unsafe rust clauses), and lacks a few features, but it still seems very fine!

@2767mr
Copy link
Member

2767mr commented May 1, 2022

I am not so sure about linking the wiki here. Also, if you include the installer then put a big disclaimer on it reguarding unstable/similar.

There is a video tutorial for installing CCLoader that may be included as well: https://www.youtube.com/watch?v=kY3_C2D2gDA

@dmitmel
Copy link
Member

dmitmel commented May 1, 2022

Also, if you include the installer then put a big disclaimer on it reguarding unstable/similar.

Yep, maybe a 'lil cleaning u, it seems quite hacked together (I saw a few unsafe rust clauses),

It is perfectly stable. The unsafe code is used to create UI without pulling in gigantic UI libraries (consider that I really only needed functions for opening dialog windows).

@Yusuto
Copy link
Author

Yusuto commented May 1, 2022

There is a video tutorial for installing CCLoader that may be included as well: https://www.youtube.com/watch?v=kY3_C2D2gDA

The Video still uses the method of downloading the source code, so maybe re-recording it might be a good idea

@dmitmel
Copy link
Member

dmitmel commented May 1, 2022

You may mention the installer, it's just that because the installation process is so simple it's kinda redundant. It was intended to be used as something more than a CCLoader installer, namely for allowing installation of modding tools into the same nwjs the game uses (as to not download the 60 MB Chromium build for each separate tool), but that was never implemented.

@2767mr
Copy link
Member

2767mr commented May 1, 2022

The Video still uses the method of downloading the source code, so maybe re-recording it might be a good idea

Downloading the source works perfectly fine for CCLoader 2.
If you want to make a new video, feel free to do it.

@Yusuto
Copy link
Author

Yusuto commented May 1, 2022

It is perfectly stable. The unsafe code is used to create UI without pulling in gigantic UI libraries (consider that I really only needed functions for opening dialog windows).

Oh, Okay, that makes sense. It seems simple enough to not be an issue to have a bit of unsafe code.

Maybe it could be replaced with a small Bash / Powershell scripts? Having an entire program with GUI and everything seems a little bit too much for now, and adding features such as updating to a Bash / Powershell script seems relatively easy.
A simple Rust TUI would be even better.

@2767mr 2767mr self-assigned this May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants