[IMPROVEMENT] Prevent Running Tests on Platform Before Build Succeed on Both OS

[Tarun-Arora]

Please prefix your pull request with one of the following: [FEATURE] [FIX] [IMPROVEMENT].

In raising this pull request, I confirm the following (please check boxes):

• I have read and understood the contributors guide.
• I have checked that another pull request for this purpose does not exist.
• I have considered, and confirmed that this submission will be valuable to others.
• I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
• I give this submission freely, and claim no ownership to its content.

My familiarity with the project is as follows (check one):

• I have never used the project.
• I have used the project briefly.
• I have used the project extensively, but have not contributed previously.
• I am an active contributor to the project.

---

Prevent Running Tests on Platform Before Build Succeed
This pull request involve making changes in the mod_ci module to re-configure the testing process, so that Tests won't start before the CCExtractor builds have been completed.

The following are the test details for various cases of triggering of platform:

• Push:

1. With GitHub Actions Failing(Both Builds Triggered) Tarun-Arora/ccextractor@acfad7b
2. With GitHub Actions Succeeding(Both Builds Triggered): Tarun-Arora/ccextractor@5347ea2
3. With GitHub Actions Succeeding(Exactly One Build Triggered): Tarun-Arora/ccextractor@c71d7aa
4. With GitHub Actions Failing(Exactly One Build Triggered): Tarun-Arora/ccextractor@5f0b005
5. With No builds triggered(no tests): Tarun-Arora/ccextractor@d222e58

• Pull Requests:

1. With GitHub Actions Failing(Both Builds Triggered): test Tarun-Arora/ccextractor#10
2. With GitHub Actions Succeeding(Both Builds Triggered): With GitHub Actions Succeeding(Both Builds Triggered) Tarun-Arora/ccextractor#9
3. With GitHub Actions Succeeding(Exactly One Build Triggered): Prbranch3 Tarun-Arora/ccextractor#16
4. With GitHub Actions Failing(Exactly One Build Triggered): test Tarun-Arora/ccextractor#12
5. With No builds triggered(no tests): test Tarun-Arora/ccextractor#14
6. PR Close, and Reopen: Prbranch3 Tarun-Arora/ccextractor#16
7. PR Update: test Tarun-Arora/ccextractor#12

• Close PR before Build completes(ensuring no adding tests after cancellation): test Tarun-Arora/ccextractor#13

[pep8speaks]

Hello @Tarun-Arora, Thank you for updating the PR!

Great work! I discovered no PEP8 issues in this Pull Request. 🥇

Comment last updated at 2022-06-13 06:06:34 UTC

[thealphadollar]

Please fix the failing tests first 🙇🏽

[Tarun-Arora]

Please fix the failing tests first 🙇🏽

Yes, I would rewrite the required failing unit tests and inform once done.

[Tarun-Arora]

Please fix the failing tests first 🙇🏽

Yes, I would rewrite the required failing unit tests and inform once done.

Done. Please Review, @thealphadollar.

[codecov]

Codecov Report

Merging #666 (e6042e2) into master (28ec53a) will increase coverage by 0.37%.
The diff coverage is 82.50%.

@@            Coverage Diff             @@
##           master     #666      +/-   ##
==========================================
+ Coverage   81.39%   81.77%   +0.37%     
==========================================
  Files          36       36              
  Lines        3607     3682      +75     
  Branches      491      518      +27     
==========================================
+ Hits         2936     3011      +75     
+ Misses        535      532       -3     
- Partials      136      139       +3     

Flag	Coverage Δ
unittests	81.77% <82.50%> (+0.37%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
mod_ci/controllers.py	65.08% <82.50%> (+3.40%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28ec53a...e6042e2. Read the comment docs.

[thealphadollar]

Thank you for the changes, I've provided small nitpicks to rename the test functions.

[thealphadollar]

LGTM. Thanks Tarun for the hard work 🙇🏽

@canihavesomecoffee Please have a look and merge.