Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add dependency check workflow #346

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

sbidari
Copy link
Collaborator

@sbidari sbidari commented Jul 30, 2024

adds dependency check to CI

@sbidari sbidari linked an issue Jul 30, 2024 that may be closed by this pull request
Copy link

codecov bot commented Jul 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.91%. Comparing base (f77579e) to head (981e35f).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #346      +/-   ##
==========================================
+ Coverage   92.80%   92.91%   +0.10%     
==========================================
  Files          39       39              
  Lines         917      917              
==========================================
+ Hits          851      852       +1     
+ Misses         66       65       -1     
Flag Coverage Δ
unittests 92.91% <ø> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sbidari sbidari marked this pull request as ready for review July 30, 2024 20:39
Copy link
Collaborator

@dylanhmorris dylanhmorris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EDIT: misread.

Copy link
Collaborator

@dylanhmorris dylanhmorris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Misread things above. LGTM.

@dylanhmorris dylanhmorris merged commit 64e0ed8 into main Jul 30, 2024
9 checks passed
@dylanhmorris dylanhmorris deleted the 338-add-a-static-dependency-checker-to-ci branch July 30, 2024 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a static dependency checker to CI
2 participants