Test convolve mode in hospitaladmissionspy

[sbidari]

changes included:

• create a helper function for convolve compute_incidence_observed_with_delay
• adds test for the helper function
• update hospital admissions tutorial and DOW tutorials to use convolve mode="valid"

closes #385

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.45%. Comparing base (769712b) to head (3efcfad).

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #398      +/-   ##
==========================================
+ Coverage   93.43%   93.45%   +0.02%     
==========================================
  Files          38       38              
  Lines        1005     1009       +4     
==========================================
+ Hits          939      943       +4     
  Misses         66       66              

Flag	Coverage Δ
unittests	93.45% <100.00%> (+0.02%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[damonbayer]

For the tutorials, I suggest computing something like n_initialization_points = max(gen_int_array.size, inf_hosp_int_array.size) and using that throughout.

[dylanhmorris]

@sbidari can you resolve the conflicts here? Then I will re-review.

[dylanhmorris]

Thanks, @sbidari. A few minor tweaks to docstrings and one major suggestion of function placement within the codebase. CC @damonbayer

[damonbayer]

@sbidari Now that we made a decision around #410, can you adopt those changes for the new names in this PR?

[sbidari]

I realized n_initialization_points needed to be max(gen_int_array.size, inf_hosp_int_array.size) - 1 instead of max(gen_int_array.size, inf_hosp_int_array.size) and made that change in 5c4395f

changes addressed