Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vectorize ARProcess() #439

Merged
merged 29 commits into from
Sep 12, 2024
Merged

Vectorize ARProcess() #439

merged 29 commits into from
Sep 12, 2024

Conversation

dylanhmorris
Copy link
Collaborator

@dylanhmorris dylanhmorris commented Sep 10, 2024

This will allow it to play better with numpyro.plate (still not seamlessly, see here), among other things

Copy link

codecov bot commented Sep 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.03%. Comparing base (bfaa0c0) to head (4c2561c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #439      +/-   ##
==========================================
+ Coverage   93.96%   94.03%   +0.06%     
==========================================
  Files          42       42              
  Lines         978      989      +11     
==========================================
+ Hits          919      930      +11     
  Misses         59       59              
Flag Coverage Δ
unittests 94.03% <100.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dylanhmorris dylanhmorris marked this pull request as ready for review September 12, 2024 16:05
pyrenew/process/ar.py Outdated Show resolved Hide resolved
pyrenew/process/ar.py Outdated Show resolved Hide resolved
pyrenew/process/ar.py Outdated Show resolved Hide resolved
pyrenew/process/ar.py Outdated Show resolved Hide resolved
pyrenew/process/ar.py Outdated Show resolved Hide resolved
@damonbayer
Copy link
Collaborator

Since one of the intended use cases of this extension is compatibility with numpyro.plate I wonder if we should do some tests with plates (and more complicated setups like nested plates. I'm not immediately sure that all this will work).

@dylanhmorris
Copy link
Collaborator Author

Since one of the intended use cases of this extension is compatibility with numpyro.plate I wonder if we should do some tests with plates (and more complicated setups like nested plates. I'm not immediately sure that all this will work).

Good point will add

@damonbayer
Copy link
Collaborator

Good point will add

I might even suggest that plate be the only way we do multi-dimensional testing.

@dylanhmorris
Copy link
Collaborator Author

Good point will add

I might even suggest that plate be the only way we do multi-dimensional testing.

I wouldn't go that far; we want vectorizations / multi-dim behavior to be as expected outside of plate contexts too, no?

@dylanhmorris dylanhmorris merged commit 3d06ab9 into main Sep 12, 2024
8 checks passed
@dylanhmorris dylanhmorris deleted the dhm-vectorize-ar branch September 12, 2024 20:31
Copy link
Collaborator

@AFg6K7h4fhy2 AFg6K7h4fhy2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirming that I have seen all changes made in this PR and (mostly) have absorbed the updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants