-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vectorize ARProcess()
#439
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #439 +/- ##
==========================================
+ Coverage 93.96% 94.03% +0.06%
==========================================
Files 42 42
Lines 978 989 +11
==========================================
+ Hits 919 930 +11
Misses 59 59
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…ization of DifferencedProcess
Since one of the intended use cases of this extension is compatibility with |
Good point will add |
I might even suggest that |
I wouldn't go that far; we want vectorizations / multi-dim behavior to be as expected outside of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirming that I have seen all changes made in this PR and (mostly) have absorbed the updates.
This will allow it to play better with
numpyro.plate
(still not seamlessly, see here), among other thingsnumpyro.scan
builds by augmenting the first dimension. So since we most often scan over time, this convention will makescan
s over time have sensible default output.jnp.einsum
. I think we should use it wherever that's the task VectorizeARProcess()
#439 (comment)