Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save endpoint can now save to a DB using the extended schema #2416

Open
2 tasks
gordonfarrell opened this issue Aug 21, 2024 · 0 comments · May be fixed by #2675
Open
2 tasks

Save endpoint can now save to a DB using the extended schema #2416

gordonfarrell opened this issue Aug 21, 2024 · 0 comments · May be fixed by #2675
Assignees
Labels
demo day Planning to show this work at demo days pairing Streamline eCR Issues for Streamline eCR team to work on

Comments

@gordonfarrell
Copy link
Collaborator

gordonfarrell commented Aug 21, 2024

What needs to be done

Upgrade our saving flow to save to the extended DB schema if so configured.

Why it needs to be done

This ticket puts all the pieces together from previous tickets to allow saving to a DB using the extended schema. We have the extra data from the message parser, an extended schema for setting up the DB, and env vars that should let us tell the system what kind of world it lives in. Lets put it all together and get savin'!

Acceptance Criteria

Given the env vars DATABASE_SCHEMA='extended', DATABASE_TYPE='sqlserver' and using the orchestration config philadelphia-ecr-viewer :

  • Write out the full eCR data json object returned from the parser into the extended schema tables. Important notes below!!!!!
  • Tests/Test updates for new and updated functions

Technical Notes

This is a write change only, we don't need to read the full extended schema

Extended Schema details in file: containers/ecr-viewer/sql/extended.sql

!!IMPORTANT!! Some of the SQL dialects we need to interact with can't handle datetime data types, so in the extended schema these have been split into two columns DATE and TIME.

Example: An eCR's encounter_start_date and encounter_start_time are two separate columns in the DB despite coming from the same string in the eCR

@gordonfarrell gordonfarrell added the Streamline eCR Issues for Streamline eCR team to work on label Aug 21, 2024
@lina-roth lina-roth assigned lina-roth and unassigned lina-roth Aug 28, 2024
@lina-roth lina-roth assigned lina-roth and unassigned lina-roth Sep 5, 2024
@JNygaard-Skylight JNygaard-Skylight self-assigned this Sep 16, 2024
@emmastephenson emmastephenson added the demo day Planning to show this work at demo days label Oct 1, 2024
@JNygaard-Skylight JNygaard-Skylight linked a pull request Oct 4, 2024 that will close this issue
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
demo day Planning to show this work at demo days pairing Streamline eCR Issues for Streamline eCR team to work on
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants