-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
End-to-End Philly Message Parser Workflow #2675
Open
JNygaard-Skylight
wants to merge
88
commits into
main
Choose a base branch
from
josh/save-extended-metadata
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-jnygaard-skylight:CDCgov/phdi into josh/update-ecr-save-to-inclide-metadata
…aard-skylight:CDCgov/phdi into josh/save-metadata-in-orchestration
* revert changes to workflow and rmeove data.sql * update database schema to core * add metadata database type * add volume for sql server * delete init.sql * Revert "add volume for sql server" This reverts commit 85d4723.
BobanL
reviewed
Oct 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of nits!
containers/ecr-viewer/src/app/api/save-fhir-data/save-fhir-data-service.ts
Outdated
Show resolved
Hide resolved
containers/ecr-viewer/src/app/api/save-fhir-data/save-fhir-data-service.ts
Outdated
Show resolved
Hide resolved
containers/ecr-viewer/src/app/api/save-fhir-data/save-fhir-data-service.ts
Outdated
Show resolved
Hide resolved
containers/ecr-viewer/src/app/api/save-fhir-data/save-fhir-data-service.ts
Outdated
Show resolved
Hide resolved
containers/ecr-viewer/src/app/api/save-fhir-data/save-fhir-data-service.ts
Outdated
Show resolved
Hide resolved
containers/ecr-viewer/src/app/api/save-fhir-data/save-fhir-data-service.ts
Show resolved
Hide resolved
…ormatting, rollback transaction if any fail
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PULL REQUEST
Summary
Enables end-to-end use of the Philly Orchestration config. Specifically saving the extended metadata to SQL Server.
Related Issue
Fixes #2416
Acceptance Criteria
Given the env vars
DATABASE_SCHEMA='extended'
,DATABASE_TYPE='sqlserver'
and using the orchestration configphiladelphia-ecr-viewer
:Additional Information
You will need the following eCR-viewer environment variables set:
Primarily you can test this by running the
process-message
endpoint:containers/orchestatrion
Start orchestration and the relevant services withdocker compose up trigger-code-reference-service message-parser-service ingestion-service fhir-converter-service validation-service orchestration-service ecr-viewer postgres sqlserver --build
message-process
endpoint with this body:To test just the
save-fhir-data
you need to first get metadata. The extended metadata is quite large so you will not want to write it manually. You can run the message-parser seperately by:README.md
incontainers/message-parser
to start the service.localhost:8080/parse-message
with this body:This should return a big JSON full of the metadata
You will need the following ENV variables set:
{
"fhirBundle": "<FHIR_BUNDLE_JSON>",
"metadata": "<METADATA_JSON>",
"saveSource": "postgres" // Or wherever you want
}