-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pd1-4 mapping to Patient.generalPractitioner #17019
Conversation
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
Integration Test Results 60 files 60 suites 43m 34s ⏱️ Results for commit 0b029d7. ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good! 👍
@@ -18,7 +18,7 @@ resourceType: Patient | |||
# to Patient.link which includes a reference to RelatedPerson | |||
|
|||
|
|||
# - PD1.4 Deprecated in NIST, set to NullDT in HAPI. Field not mapped | |||
# - PD1.4 Backwards compatible in NIST. Needed for ETOR NBS use case. Mapped to Patient.generalPractitioner. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a whole heap of context for what this comment is referring to (you can ignore this if you're already aware). The HAPI library will set the object type of some fields to NULLDT (as opposed to String or CE or XCN, etc.) which effectively means values cannot be mapped to those fields. To get around this we have been importing and modifying some of the java classes from HAPI so that we can set field to the most universal types.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me! Only thought would be to maybe update one of the integration tests for the ETOR use case to make sure that ORM -> FHIR is working for their sample
Hey Michael! Just want to clarify this is for the ETOR use case. Our partners are able to send us OML_O21 messages as it turns out so that's what we're mapping here. There's a couple more backwards compatible fields we'll be mapping but they are all for message type OML_021 |
@GilmoreA6 Got it that makes sense! |
Quality Gate passedIssues Measures |
Progresses #15503. |
This PR adds mapping for PD1-4. The field is backwards compatible in NIST/HL7 2.5.1 and we are adding to support the ETOR NBS use case. In FHIR, the field maps to/from
Patient.generalPractitioner
.Test Steps:
test OML_O21 all segments
andtest PD1 populated with PD1-14-1 populated
.Changes
Patient.generalPractitioner
Practitioner reference. Note that PD1-3 maps toPatient.generalPractitioner
, but uses an organization reference. Both fields support repetitions.Checklist
Testing
./prime test
or./gradlew testSmoke
against local Docker ReportStream container?Process
Linked Issues
Specific Security-related subjects a reviewer should pay specific attention to
If you answered 'yes' to any of the questions above, conduct a detailed Review that addresses at least: