Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding the twostep container action from CDCgov/cfa-actions #245

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gvegayon
Copy link
Member

It replaces the container workflow with the action from https://github.com/CDCgov/cfa-actions/.

@gvegayon gvegayon marked this pull request as ready for review December 14, 2024 20:28
Copy link

codecov bot commented Dec 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 13.04%. Comparing base (c615c45) to head (4f2198e).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #245   +/-   ##
=======================================
  Coverage   13.04%   13.04%           
=======================================
  Files           9        9           
  Lines         820      820           
=======================================
  Hits          107      107           
  Misses        713      713           
Flag Coverage Δ
python-tests 1.91% <ø> (ø)
r-tests 22.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@damonbayer
Copy link
Collaborator

I am actually in the middle of modifying the actions here: #242

Would I be able to achieve my goal with the CFA actions?

@gvegayon
Copy link
Member Author

Build args are currently hard-coded in the action, but adding that as an option would be awesome. I don't think it will be hard to do. I will add the feature and ping you when it's ready. I can start now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants