Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created 'Create Section' page, hooked in with real data and added translations #216

Open
wants to merge 5 commits into
base: development
Choose a base branch
from

Conversation

jupiter007
Copy link
Collaborator

@jupiter007 jupiter007 commented Dec 20, 2024

Description

Created the "Create Section" page, which will be different from "Edit Section" page, primarily because we won't be setting a Section ID until the user successfully creates a new section.

  • Created a new page at: template/[templateId]/section/create
  • Styles with css modules and added unit test for new page
  • Add translations
  • Added new icon for info to be used next to the tags
  • components/Editor
    -- updated components/Editor to use a skeleton to display until the editor loads. This became more of a problem as more instances of that DMPEditor were included in the same page.
    -- switched components/Editor to use css modules
    -- added two new props, error and id to the component
  • Added AddSection and Tags mutation and query

Fixes # (187)

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

This was tested both manually and using unit tests.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I updated the CHANGELOG.md and added documentation if necessary
  • I have added tests that prove my fix is effective or that my feature works
  • I have completed manual or automated accessibility testing for my changes
  • New and existing unit tests pass locally with my changes
  • [NA] Any dependent changes have been merged and published in downstream modules

Screenshots

image image image

@jupiter007 jupiter007 requested review from fraserclark, andrewebdev and briri and removed request for fraserclark December 20, 2024 19:47
@jupiter007 jupiter007 changed the title Update Created Section page to work with real data and to add translations Created 'Create Section' page to work with real data and to add translations Dec 20, 2024
@jupiter007 jupiter007 changed the title Created 'Create Section' page to work with real data and to add translations Created 'Create Section' page, hooked in with real data and added translations Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant