[feat] 메일링 서비스 기능 구현 #168
Merged
[feat] 메일링 서비스 기능 구현 #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suhhyun524
requested review from
hyunihs,
mushroom1324,
haen-su and
mirageoasis
as code owners
mirageoasis
reviewed
Jan 12, 2024
|
|
||
| @Component | ||
| @RequiredArgsConstructor | ||
| public class SubscriberHelper { |
There was a problem hiding this comment.
궁금한게 보통 helper 클래스를 만드나요? 뭔가 현재 복잡성으로는 서비스 계층에 함수를 넣으면 될 것 같은데 helper 클래스를 만드는 이유가 있나요? 코드는 이상 없습니다!
There was a problem hiding this comment.
서비스 계층에서는 메서드만 불러와서 사용해서 코드 가독성을 높이고 싶엇습니다
hyunihs
reviewed
Jan 15, 2024
hyunihs
approved these changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 PR Summary - 메일링 서비스 기능 구현
📝 Description
동아리 기수 모집 알림 메일을 보내는 서비스를 구현하였습니다.
모집일에 ROOT 유저가 api 호출 시 위와 같은 메일이 발송됩니다.
추후 메일 본문을 수정할 예정입니다.
🌲 Working Branch
feat/recruit
📖 Related Issues
이슈 번호