OIDC: Plugin-customizable OpenIDProvider class #982
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
What is the current behaviour?
This PR addresses #965. Depending on the OpenID Provider, usually provider offers additional resources that may tell us more about the specific user, but these resources are non-standard and specific for the provider. We may want to have a dedicated handler for these specific providers
What is the new behaviour?
mwdb.model.oauth.OpenIDProvider
(now calledOpenIDProviderSettings
) andmwdb.core.oauth.OpenIDClient
-mwdb.core.oauth.provider.OpenIDProvider
that implements user and group creation and can be used to create own customized OpenIDProvider classesPluginAppContext.register_openid_provider_class
methodTest plan
Closing issues
closes #965