Performance improvement 3: simplify queries #195
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm a bit disasppointed in this PR - TBH I expected another big win, while it turned out to be mediocre.
Nevertheless there are some improvements here, and the code is not too complex, so I think it's worth merging (I rejected a few ideas that turned out to be complex to implement for almost zero benefit).
As usual, results can be seen in this repo: https://github.com/msm-code/ursa-bench temporarily hosted here: http://65.21.130.153:8000/hdd_all.html
Ok, but what's going on in the code?
Basically we flatten queries:
And we handle minof special cases:
(should be merged after improvements 2)