Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add option to use 16bits hash in lyb #2188

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

billykinggym
Copy link

lyb hash only has 8bits, which not sufficient in some cases
this PR add a compile option that the devolper could set the hash size to 16bit if needed. by default , the value is 8bit as before.

@michalvasko
Copy link
Member

Yes, the hash size is actually in public API which makes libraries with 8b vs 16b hashes incompatible not just when communicating using LYB but even their ABIs. And there are only a few changes needed, is it necessary to be merged into the repo? To keep things simple, I would prefer you keep it as a local patch. Like I said, the libraries are not compatible when the hash size changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants