SplineBuilder doc #409
Merged
SplineBuilder doc #409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion/ddc into clarify-spline-names
EmilyBourne
reviewed
Apr 16, 2024
EmilyBourne
reviewed
Apr 16, 2024
EmilyBourne
reviewed
Apr 16, 2024
EmilyBourne
reviewed
Apr 16, 2024
EmilyBourne
reviewed
Apr 16, 2024
EmilyBourne
reviewed
May 3, 2024
EmilyBourne
reviewed
May 3, 2024
EmilyBourne
reviewed
May 3, 2024
EmilyBourne
reviewed
May 3, 2024
EmilyBourne
reviewed
May 3, 2024
EmilyBourne
reviewed
May 3, 2024
EmilyBourne
reviewed
May 3, 2024
EmilyBourne
reviewed
May 3, 2024
Co-authored-by: EmilyBourne <[email protected]>
EmilyBourne
reviewed
May 3, 2024
EmilyBourne
previously approved these changes
May 6, 2024
EmilyBourne
previously approved these changes
May 16, 2024
tpadioleau
reviewed
May 27, 2024
| * @param x The SplineBuilder being copied. | ||
| * @returns A reference to this object. | ||
| * @param x An rvalue to another SplineBuilder. | ||
| * @return A reference to the moved SplineBuilder |
There was a problem hiding this comment.
Isn't it x that is "moved" ?
There was a problem hiding this comment.
to the SplineBuilder once moved ?
There was a problem hiding this comment.
@tpadioleau I think this is the last remaining comment here, to me something can be qualified as "moved" only once it has been moved, and only the moved thing not the remaining empty place where it comes from. But this is a bit too philisophical to me so please suggest something if you don't agree ^^
There was a problem hiding this comment.
I would keep the original doc on the return section. The reference is really on the object *this, not the object that has been moved, x.
| * The temporary SplineBuilder2D being copied. | ||
| * @returns A reference to this object. | ||
| * @param x An rvalue to another SplineBuilder. | ||
| * @return A reference to the moved SplineBuilder |
Co-authored-by: Thomas Padioleau <[email protected]>
Co-authored-by: Thomas Padioleau <[email protected]>
Merged
tpadioleau
requested changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.