Use Kokkos 4.4.01 with mdspan coming from Kokkos #651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tpadioleau
force-pushed
the
604-conflict-between-mdspan-and-kokkos-4400
branch
7 times, most recently
from
bdfa078
to
0672aa0
Compare
tpadioleau
force-pushed
the
604-conflict-between-mdspan-and-kokkos-4400
branch
4 times, most recently
from
6c80bc1
to
d3ad777
Compare
@tpadioleau Did you open an issue on Kokkos about this? |
Not yet, we should do it at some point. It is not critical now that we have found a workaround. |
yasahi-hpc
requested changes
Sep 30, 2024
tpadioleau
force-pushed
the
604-conflict-between-mdspan-and-kokkos-4400
branch
from
c16ad68
to
49c8924
Compare
tpadioleau
force-pushed
the
604-conflict-between-mdspan-and-kokkos-4400
branch
from
49c8924
to
3d803f3
Compare
|
@acalloo do you still want to do a review or should I merge ? Edit: Ansar is ok to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
std::experimental::mdspantoKokkos::mdspan,layout_[left|right]_paddedreturned bysubmdspantolayout_stride,The reason I use the strategy 3. is that
submdspanmay return alayout_left_padded/layout_right_paddedlayout. Although these layouts should map to KokkosLayoutLeft/LayoutRight, I could not find in Kokkos 4.4.01 any public API to construct a Kokkos layout with the padding value.