Add functions to compute discrete curvature #6088
Open
+383
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Shall we plug it in the display plugin ? |
That would be a nice way to evaluate the code. |
|
Done. Here is what it looks like |
MaelRL
reviewed
Nov 2, 2021
Polygon_mesh_processing/include/CGAL/Polygon_mesh_processing/internal/curvature.h
Outdated
Show resolved
Hide resolved
afabri
reviewed
Dec 10, 2021
| const Vector_3 cross = cross_product(v0, v1); | ||
| const FT sqcn = squared_length(cross); | ||
| if(dot == FT(0)) | ||
| ki += CGAL_PI/FT(2); |
There was a problem hiding this comment.
Not sure this will compile with Epeck.
afabri
reviewed
Dec 10, 2021
Polygon_mesh_processing/include/CGAL/Polygon_mesh_processing/internal/curvature.h
Outdated
Show resolved
Hide resolved
|
Is that going to be documented and submitted as a small feature? |
MaelRL
added
the
Not yet approved
|
Successfully tested in CGAL-6.1-Ic-45 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add internal functions to compute discrete curvature