Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mesh_3 - update benchmark #7883

Merged
merged 17 commits into from
May 31, 2024
Merged

Mesh_3 - update benchmark #7883

merged 17 commits into from
May 31, 2024

Conversation

janetournois
Copy link
Member

@janetournois janetournois commented Nov 24, 2023 •
edited by MaelRL
Loading

Summary of Changes

Fix compilation of Mesh_3 benchmark with recent API of TBB.

Add benchmarking scripts to evaluate and chart Mesh_3's performance, robustness, and quality.

Release Management

  • Affected package(s): Mesh_3
  • License and copyright ownership: unchanged

@janetournois janetournois added this to the 6.0-beta milestone Nov 24, 2023
@janetournois janetournois marked this pull request as draft November 24, 2023 13:25
@sloriot sloriot added Batch_1 First Batch of PRs under testing Under Testing and removed Batch_1 First Batch of PRs under testing labels Nov 28, 2023
@MaelRL MaelRL marked this pull request as ready for review December 11, 2023 11:29
@MaelRL MaelRL changed the title Mesh_3 - update benchmark with TBB Mesh_3 - update benchmark Dec 11, 2023
@sloriot
Copy link
Member

sloriot commented May 15, 2024

Successfully tested in CGAL-6.0-Ic-242

@lrineau lrineau self-assigned this May 16, 2024
@lrineau
Copy link
Member

lrineau commented May 16, 2024

This PR #7883 is really nice: it resuscitate the old Mesh_3 benchmark, made by @cjamin about 10 years ago. Now it will work again (@MaelRL will check locally), with recent improvements, and we might add it soon to a CGAL benchmark-suite (... that @SaillantNicolas will implement).

I will merge it as soon as Mael confirms the benchmark system will compile and work...

@lrineau
Copy link
Member

lrineau commented May 16, 2024

@MaelRL Please merge master.

@lrineau
Copy link
Member

lrineau commented May 28, 2024

@MaelRL Please merge master.

Ping @MaelRL

@github-actions github-actions bot removed the Tested label May 29, 2024
@github-actions GitHub Actions
Copy link

This pull-request was previously marked with the label Tested, but has been modified with new commits. That label has been removed.

@sloriot
Copy link
Member

sloriot commented May 31, 2024

Successfully tested in CGAL-6.0-Ic-256

@lrineau lrineau added the rm only: ready for master For the release team only: that indicates that a PR is about to be merged in 'master' label May 31, 2024
@lrineau lrineau merged commit 5ffa817 into CGAL:master May 31, 2024
9 checks passed
@lrineau lrineau removed the rm only: ready for master For the release team only: that indicates that a PR is about to be merged in 'master' label May 31, 2024
@lrineau lrineau deleted the Mesh_3-update_benchmark-jtournois branch May 31, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lrineau lrineau lrineau left review comments

@MaelRL MaelRL MaelRL left review comments

Assignees

@lrineau lrineau

Labels
Merged_in_6.0 Pkg::Mesh_3 Speed Tested
Projects
None yet
Milestone
6.0-beta
Development

Successfully merging this pull request may close these issues.
4 participants
@janetournois @sloriot @lrineau @MaelRL