-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] CGAL 3D conforming constrained Delaunay triangulation #8186
Draft
lrineau
wants to merge
492
commits into
CGAL:master
Choose a base branch
from
lrineau:Triangulation_3-CDT_3-lrineau
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+93,078
−1,306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That means it could be replaced by a const member function
Now the two functions are adjacent: - `try_to_insert_circumcenter_in_face_or_return_encroached_edge` and - `insert_mid_point_in_constrained_edge`
to a member function
The code review found that as a bug, but it never showed.
Now it seems to work!
Facets are pushed directly as mirror facets, on the border of the cavity so that they are seen from the exterior of the cavity. That avoids a copy of a vector of facets.
That addresses a TODO from Jane's review.
Now CTest displays: ``` Start 5393: execution of cdt_3_from_off --merge-facets Thingi10K_106789 Start 5392: execution of cdt_3_from_off Thingi10K_106789 4/6 Test CGAL#5392: execution of cdt_3_from_off Thingi10K_106789 ..................***Not Run (Disabled) 0.00 sec 5/6 Test CGAL#5393: execution of cdt_3_from_off --merge-facets Thingi10K_106789 ... Passed 0.10 sec ```
That avoids having to hardcode the assertion expression in the code
The lack of `std::set::contains` is a real pain! Using `count()` instead reduces the readability of the code.
/build:v2 |
The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/8186/v2/Manual/index.html |
Constrained_triangulation_3/include/CGAL/make_conforming_constrained_Delaunay_triangulation_3.h
Outdated
Show resolved
Hide resolved
Constrained_triangulation_3/include/CGAL/Conforming_constrained_Delaunay_triangulation_3.h
Outdated
Show resolved
Hide resolved
Constrained_triangulation_3/include/CGAL/Conforming_constrained_Delaunay_triangulation_3.h
Outdated
Show resolved
Hide resolved
and display the exit code
Jane approved the changes after a quick look. The corresponding update for the class constructors will follow soon.
/build:v3-wip |
There was an error while building the doc:
|
janetournois
reviewed
Dec 5, 2024
Constrained_triangulation_3/include/CGAL/make_conforming_constrained_Delaunay_triangulation_3.h
Outdated
Show resolved
Hide resolved
Co-authored-by: Jane Tournois <[email protected]>
I have added comments on the block of code that triangulates the polygon on-the-fly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CHANGES.md not updated
Feature
Not yet approved
The feature or pull-request has not yet been approved.
Pkg::Triangulation_3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This submission contributes 3D Constrained Delaunay triangulations to CGAL.
TODO list
Release Management
Affected package(s): new package, with a few modified packages (TBD...)
Feature/Small Feature (if any): Features/3D Constrained Delaunay triangulations
Link to compiled documentation: ref manual (wip), package overview (wip), missing user manual
License and copyright ownership: GPLv3+, owned by GeometryFactory