Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] CGAL 3D conforming constrained Delaunay triangulation #8186

Draft
wants to merge 492 commits into
base: master
Choose a base branch
from

Conversation

lrineau
Copy link
Member

@lrineau lrineau commented May 6, 2024

Summary of Changes

This submission contributes 3D Constrained Delaunay triangulations to CGAL.

TODO list

Preview Give feedback

Release Management

That means it could be replaced by a const member function
Now the two functions are adjacent:
- `try_to_insert_circumcenter_in_face_or_return_encroached_edge` and
- `insert_mid_point_in_constrained_edge`
The code review found that as a bug, but it never showed.
Now it seems to work!
Facets are pushed directly as mirror facets, on the border of the cavity
so that they are seen from the exterior of the cavity.

That avoids a copy of a vector of facets.
That addresses a TODO from Jane's review.
Now CTest displays:
```
    Start 5393: execution   of  cdt_3_from_off --merge-facets Thingi10K_106789
    Start 5392: execution   of  cdt_3_from_off Thingi10K_106789
4/6 Test CGAL#5392: execution   of  cdt_3_from_off Thingi10K_106789 ..................***Not Run (Disabled)   0.00 sec
5/6 Test CGAL#5393: execution   of  cdt_3_from_off --merge-facets Thingi10K_106789 ...   Passed    0.10 sec
```
That avoids having to hardcode the assertion expression in the code
The lack of `std::set::contains` is a real pain! Using `count()`
instead reduces the readability of the code.
@lrineau
Copy link
Member Author

lrineau commented Nov 12, 2024

/build:v2

Copy link

The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/8186/v2/Manual/index.html

@lrineau
Copy link
Member Author

lrineau commented Dec 4, 2024

/build:v3-wip

Copy link

github-actions bot commented Dec 4, 2024

There was an error while building the doc:

doc_fragments/CDT_3_common_named_parameters.dox:1: warning: Found unknown command '\cgalParamNBegin'
doc_fragments/CDT_3_common_named_parameters.dox:2: warning: Found unknown command '\cgalParamDescription'
doc_fragments/CDT_3_common_named_parameters.dox:3: warning: Found unknown command '\cgalParamType'
doc_fragments/CDT_3_common_named_parameters.dox:4: warning: Found unknown command '\cgalParamDefault'
doc_fragments/CDT_3_common_named_parameters.dox:5: warning: Found unknown command '\cgalParamNEnd'
doc_fragments/CDT_3_common_named_parameters.dox:1: warning: Found unknown command '\cgalParamNBegin'
doc_fragments/CDT_3_common_named_parameters.dox:2: warning: Found unknown command '\cgalParamDescription'
doc_fragments/CDT_3_common_named_parameters.dox:3: warning: Found unknown command '\cgalParamType'
doc_fragments/CDT_3_common_named_parameters.dox:4: warning: Found unknown command '\cgalParamDefault'
doc_fragments/CDT_3_common_named_parameters.dox:5: warning: Found unknown command '\cgalParamNEnd'

https://github.com/CGAL/cgal/actions/runs/12157880591

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CHANGES.md not updated Feature Not yet approved The feature or pull-request has not yet been approved. Pkg::Triangulation_3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants