Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CGAL::IO::read_OM() #8427

Merged
merged 35 commits into from
Nov 14, 2024
Merged

Add CGAL::IO::read_OM() #8427

merged 35 commits into from
Nov 14, 2024

Conversation

afabri
Copy link
Member

@afabri afabri commented Aug 22, 2024 •
edited by sloriot
Loading

Summary of Changes

Add a function to read an OpenMesh file ( *.om ) in CGALlab. This file format stores also edges and vertices marked as features.
For the moment the function itself is not documented.

Release Management

  • License and copyright ownership: GeometryFactory

@afabri afabri requested a review from janetournois August 22, 2024 14:07
@afabri afabri self-assigned this Aug 22, 2024
@afabri afabri added this to the 6.1-beta milestone Aug 22, 2024
janetournois
janetournois reviewed Aug 23, 2024
View reviewed changes
Lab/demo/Lab/Plugins/IO/OM_io_plugin.cpp Outdated Show resolved Hide resolved
Lab/demo/Lab/Plugins/IO/OM_io_plugin.cpp Show resolved Hide resolved
Lab/demo/Lab/Plugins/IO/OM_io_plugin.cpp Outdated Show resolved Hide resolved
STL_Extension/include/CGAL/hash_openmesh.h Outdated Show resolved Hide resolved
Stream_support/include/CGAL/IO/OM.h Outdated Show resolved Hide resolved
Stream_support/include/CGAL/IO/OM.h Outdated Show resolved Hide resolved
@MaelRL MaelRL added the Not yet approved The feature or pull-request has not yet been approved. label Aug 27, 2024
@janetournois janetournois added the depends on another PR This pull-request should only be merged after other ones. label Sep 5, 2024
@janetournois
Copy link
Member

In the demo, loading a .om file containing a surface mesh that has no feature vertices and no feature edges should not create a selection item.
This PR should be modified to have this behaviour

@janetournois janetournois removed the depends on another PR This pull-request should only be merged after other ones. label Sep 10, 2024
@sloriot
Copy link
Member

sloriot commented Sep 17, 2024

Cannot open include file: 'CXGAL/IO/OM.h'

@github-actions github-actions bot removed the Tested label Oct 23, 2024
@github-actions GitHub Actions
Copy link

This pull-request was previously marked with the label Tested, but has been modified with new commits. That label has been removed.

@sloriot
Copy link
Member

sloriot commented Oct 24, 2024

/home/cgal-testsuite/cgal_doc_build/CGAL-6.1-Ic-3/include/CGAL/IO/polygon_mesh_io.h:84: warning: unable to resolve reference to 'IOStreamOM' for \ref command

@sloriot sloriot requested a review from MaelRL November 6, 2024 12:44
@afabri
Copy link
Member Author

afabri commented Nov 8, 2024

Do we have to say that this needs OM installed as third party library? Because we have not written functions for writing ourselves.

@janetournois
Copy link
Member

Indeed it needs OpenMesh and it should be documented

@sloriot
Copy link
Member

sloriot commented Nov 8, 2024

it is already documented
\note This function is only available if OpenMesh is available (CGAL_USE_OPENMESHis defined or CMake target is linked withCGAL::OpenMesh_support).

@sloriot sloriot added Tested and removed Not yet approved The feature or pull-request has not yet been approved. Ready to be tested Under Testing labels Nov 14, 2024
@sloriot
Copy link
Member

sloriot commented Nov 14, 2024

Successfully tested in 6.1-Ic-18/19

@sloriot sloriot merged commit 74ea8b1 into CGAL:master Nov 14, 2024
9 checks passed
@sloriot sloriot deleted the BGL-Openmesh_selection-GF branch November 14, 2024 13:12
@janetournois janetournois mentioned this pull request Nov 15, 2024
Merged
sloriot added a commit that referenced this pull request Nov 20, 2024
@sloriot
IO of OpenMesh files - use doubles instead of floats (#8612)
0957261 
## Summary of Changes

The default OpenMesh point type is made of `float`s. This PR changes the
traits we use in CGAL to you `double`s and ensure that reading an
off/writing an om/reading om gives the same result back.
This PR completes #8427

## Release Management

* Affected package(s): BGL, Demo
* License and copyright ownership: unchanged
@janetournois janetournois mentioned this pull request Dec 3, 2024
Merged
@MaelRL MaelRL added the CGAL I/O label Dec 4, 2024
sloriot added a commit that referenced this pull request Dec 4, 2024
@sloriot
IO OpenMesh - fix boundary halfedges (#8640)
733b085 
## Summary of Changes

In OpenMesh, the outgoing halfedge of a boundary vertex must be the
boundary halfedge.
This PR fixes this orientation issue before writing the file, inside
`write_OM()`

This PR completes #8427 and #8612 

## Release Management

* Affected package(s): BGL
* License and copyright ownership: unchanged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janetournois janetournois janetournois left review comments

@MaelRL MaelRL MaelRL left review comments

@sloriot sloriot sloriot left review comments

Assignees

@afabri afabri

Labels
CGAL I/O Enhancement Pkg::BGL Tested
Projects
None yet
Milestone
6.1-beta
Development

Successfully merging this pull request may close these issues.
4 participants
@afabri @janetournois @sloriot @MaelRL