Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove usage of \htmlonly with <div> #8562

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

albert-github
Copy link
Contributor

The HTML <div> construct with attributes is supported by doxygen (in HTML, on other places it is ignored) and can theerfore be removed.

  • the advantage is that a mismatch of <div> / </div> is notice (e.g. when they are in different ALIASES and one of the 2 has been forgotten, see also Warnings regarding non closed tags. #8560)
  • the ALIASES: cgalModifBegin and cgalModifEnd are not used (anymore) and are therefore removed

The HTML `<div>` construct with attributes is supported by doxygen (in HTML, on other places it is ignored) and can theerfore be removed.
- the advantage is that a mismatch of `<div>` / `</div>` is notice (e.g. when they are in different `ALIASES` and one of the 2 has been forgotten, see also CGAL#8560)
- the `ALIASES`: `cgalModifBegin` and `cgalModifEnd` are not used (anymore) and are therefore removed
@afabri
Copy link
Member

afabri commented Oct 20, 2024

What do you mean with that cgalModifBegin are not used. They do not appeal in the master branch but they are useful when proposing changes in the manual. So they are just needed for "development".

After review:
- reinstated the `ALIASES`: `cgalModifBegin` and `cgalModifEnd` that might be used during development.
@albert-github
Copy link
Contributor Author

Reinstated the"modif" ALIASES.

  • what to do with the \latexonly part ?
  • interesting question is are these 2 ALIASES filtered out when a release is made so they won't accidentally slip into a release?

Another place where `\htmlonly` can be removed
@afabri
Copy link
Member

afabri commented Dec 3, 2024

I think we could give up \latexonly as we have no ambition to create something like pdf. @MaelRL any opinion?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants