Fix dangling reference in Construct_center_3(Circle_3) #8586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the issue, but it could still be broken e.g. by a kernel that is based on a CGAL kernel, but redefines the Sphere_3 and with Sphere_3-functor that would not return a const& (or in that case the custom kernel needs to define the appropriate functors too...) But so much breaks into this configuration, that it's out of scope for this fix.
mglisse
reviewed
Nov 4, 2024
|
Errors in I-c-12 |
Within the operator(), we do mostly what was done in separate functors before, but can now be done in the same function because even though the return type (deduced by decltype(auto)) is not the same for each 'if' block, the C++17 constexpr allows different return types in the different blocks. Not only we factorize code, but we do not have to use result_types anymore, and we can get the true result_type thanks to decltype() on the actual functor + parameters call.
|
Changing the target induces conflicts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
In the chain of going from a 3D circle to its center was a copy among const&.
The PR fixes the issue, but there are still some functors that return
const&assuming the rep provides one. Thus, you could do obtain something broken if you (for example) based a new kernel on a CGAL kernel, but redefined some of the objects to remove some const&, while keeping all the corresponding functors. But a lot more can go wrong with these configurations that it's out of scope for this PR.Also add missing tests for EPICK & EPECK.
Release Management
Kernel_23