Fixing ICPC usage with modern cmake and wrappers #8628
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tournois # Conflicts: # Mesh_3/include/CGAL/Mesh_3/Refine_facets_3.h
…s' into BGL-Openmesh_selection-GF # Conflicts: # BGL/examples/BGL_OpenMesh/CMakeLists.txt
## Summary of Changes Do not include `Exact_predicates_inexact_constructions_kernel.h` and `Simple_cartesian.h`. Change order of `#include` statements so that the T2 files come first. Forward declare `Epick` in `Constrained_triangulation_plus_2` where it is used for defining a `Default` for the template parameter (which is not documented). ## Release Management * Affected package(s): Triangulation_2 * License and copyright ownership: unchanged.
## Summary of Changes Fixes example mesh_3D_gray_vtk_image. Changed : Meshing all value **under** isovalue --> Meshing all values **over** isovalue. ## Release Management * Affected package(s): Mesh_3 * Issue(s) solved (if any): * Feature/Small Feature (if any): n/a * License and copyright ownership: no change
## Summary of Changes An uninitialized variable gets assigned a value inside a `for` loop, The compiler cannot know that we always enter the loop and [warns]( https://cgal.geometryfactory.com/CGAL/testsuite/CGAL-6.1-Ic-15/Polygon_mesh_processing_Examples/TestReport_lrineau_Ubuntu-latest-GCC6-Release.gz) when we later use the variable. We could use `[[assume(x)]]` to indicate that we always will enter the loop but just initializing does the job. ## Release Management * Affected package(s): PMP * License and copyright ownership: unchanged
Spelling correction
Spelling correction
## Summary of Changes Add a function to read an OpenMesh file ( `*.om` ) in CGALlab. This file format stores also edges and vertices marked as features. For the moment the function itself is not documented. ## Release Management * License and copyright ownership: GeometryFactory
## Summary of Changes Separate toggle button classes to prevent unwanted interactions between Open/Close All functionality and Third Party Libraries display
Co-authored-by: Sebastien Loriot <[email protected]>
## Summary of Changes The default OpenMesh point type is made of `float`s. This PR changes the traits we use in CGAL to you `double`s and ensure that reading an off/writing an om/reading om gives the same result back. This PR completes CGAL#8427 ## Release Management * Affected package(s): BGL, Demo * License and copyright ownership: unchanged
Related to conan's conan-io/conan-center-index#25843 replaced 'fp-model strict' by 'fp-model=strict' https://www.intel.com/content/www/us/en/docs/cpp-compiler/developer-guide-reference/2021-8/fp-model-fp.html for more compatibility with nvcc. as 'fp-model=strict' will be directly transmited to the compiler while 'fp-model strict' will have 'strict' being treated as a file input. Also added a CXX only filter for newer cmake 3.3+
|
Need basing against 6.X |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Related to conan's conan-io/conan-center-index#25843
replaced 'fp-model strict' by 'fp-model=strict' https://www.intel.com/content/www/us/en/docs/cpp-compiler/developer-guide-reference/2021-8/fp-model-fp.html for more compatibility with nvcc. as 'fp-model=strict' will be directly transmited to the compiler while 'fp-model strict' will have 'strict' being treated as a file input.
Also added a CXX only filter for newer cmake 3.3+
Release Management