Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create #8561dibya #8653

Closed
wants to merge 2 commits into from
Closed

Create #8561dibya #8653

wants to merge 2 commits into from

Conversation

debx4
Copy link

@debx4 debx4 commented Dec 11, 2024

Please use the following template to help us managing pull requests.

Summary of Changes

Describe what your pull request changes to CGAL (this can be skipped if it solves an issue already in the tracker or if it is a Feature or Small Feature submitted to the CGAL Wiki).

Release Management

  • Affected package(s):
  • Issue(s) solved (if any): fix #0000, fix #0000,...
  • Feature/Small Feature (if any):
  • Link to compiled documentation (obligatory for small feature) wrong link name to be changed
  • License and copyright ownership:

Copy link
Author

@debx4 debx4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done the edit in set(CGAL_IPELETS ${CGAL_IPELETS} simple_triangulation)

@sloriot
Copy link
Member

sloriot commented Dec 11, 2024

Your pull-request is not "valid", you should directly modify the file you want to patch in a branch from your remote and then open the PR against master like you did.

@debx4 debx4 closed this Dec 12, 2024
@debx4 debx4 reopened this Dec 12, 2024
@debx4
Copy link
Author

debx4 commented Dec 12, 2024

i open a new branch and try to patch up the branch but merging in the base branch is blocked

@MaelRL
Copy link
Member

MaelRL commented Dec 13, 2024

It's OK to work on this branch: https://github.com/debx4/cgal/tree/debx4-patch-1 and open this PR as you did.

What @sloriot meant is that you want to modify this file: https://github.com/debx4/cgal/blob/debx4-patch-1/CGAL_ipelets/demo/CGAL_ipelets/CMakeLists.txt. Instead, you created a new file: https://github.com/debx4/cgal/blob/debx4-patch-1/%238561dibya, at the root of the CGAL folder.

The following guide is quite complete and could be useful: https://docs.github.com/en/get-started/exploring-projects-on-github/contributing-to-a-project

@debx4 debx4 closed this by deleting the head repository Dec 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants