-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reworked version of Config Broker #3
Merged
davidchisnall
merged 3 commits into
CHERIoT-Platform:main
from
PhilDay-CT:config_broker_v2
Jul 29, 2024
Merged
Reworked version of Config Broker #3
davidchisnall
merged 3 commits into
CHERIoT-Platform:main
from
PhilDay-CT:config_broker_v2
Jul 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonarnell
reviewed
Jul 24, 2024
simonarnell
reviewed
Jul 24, 2024
simonarnell
reviewed
Jul 24, 2024
simonarnell
reviewed
Jul 24, 2024
simonarnell
reviewed
Jul 24, 2024
nwf
reviewed
Jul 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This remains a delight to see and thank you so much for taking the time. Still making my way through, but some initial suggestions (do feel free to ignore any/all).
configuration_broker/parser
is a bit of a mashup between reusable components and things specific to this example deployment. Could it be worth splitting that?
rmn30
reviewed
Jul 25, 2024
simonarnell
reviewed
Jul 25, 2024
simonarnell
reviewed
Jul 26, 2024
- Split parsers into seperate compartments - JSON parser moved to a library - Make use of namespaces - doc style comments where relevant - diagrams in readMe switched to mermaid - Make consumer threads exit - Various typos fixed
@PhilDay-CT thanks for considering my comments, looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The is a rework of the Configuration Broker Demo, in a much more realistic form.
Note: The JSON parser is built around a couple of files copied in from FreeRTOS