Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reworked version of Config Broker #3

Merged
merged 3 commits into from
Jul 29, 2024

Conversation

PhilDay-CT
Copy link
Contributor

The is a rework of the Configuration Broker Demo, in a much more realistic form.

  • Incoming values are now serialised JSON, as might be expected from an MQTT broker
  • Values are more realistic rather than purely abstract test values
  • JSON parsing is the main focus of the sandbox containment

Note: The JSON parser is built around a couple of files copied in from FreeRTOS

configuration_broker/config_broker/config_broker.cc Outdated Show resolved Hide resolved
configuration_broker/config_broker/config_broker.cc Outdated Show resolved Hide resolved
configuration_broker/config_broker/config_broker.cc Outdated Show resolved Hide resolved
configuration_broker/config_broker/config_broker.cc Outdated Show resolved Hide resolved
configuration_broker/config_broker/config_broker.cc Outdated Show resolved Hide resolved
configuration_broker/doc/broker.puml Outdated Show resolved Hide resolved
configuration_broker/logger/logger.h Outdated Show resolved Hide resolved
configuration_broker/parser/parser.cc Outdated Show resolved Hide resolved
Copy link
Member

@nwf nwf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This remains a delight to see and thank you so much for taking the time. Still making my way through, but some initial suggestions (do feel free to ignore any/all).

  • configuration_broker/parser is a bit of a mashup between reusable components and things specific to this example deployment. Could it be worth splitting that?

configuration_broker/README.md Outdated Show resolved Hide resolved
configuration_broker/README.md Outdated Show resolved Hide resolved
configuration_broker/README.md Outdated Show resolved Hide resolved
configuration_broker/README.md Outdated Show resolved Hide resolved
configuration_broker/config_broker/config_broker.h Outdated Show resolved Hide resolved
configuration_broker/consumers/consumer1.cc Show resolved Hide resolved
configuration_broker/parser/parser.cc Outdated Show resolved Hide resolved
configuration_broker/config_broker/config_broker.cc Outdated Show resolved Hide resolved
configuration_broker/config_broker/config_broker.cc Outdated Show resolved Hide resolved
configuration_broker/config_broker/config_broker.cc Outdated Show resolved Hide resolved
 - Split parsers into seperate compartments
 - JSON parser moved to a library
 - Make use of namespaces
 - doc style comments where relevant
 - diagrams in readMe switched to mermaid
 - Make consumer threads exit
 - Various typos fixed
@simonarnell
Copy link

@PhilDay-CT thanks for considering my comments, looks good to me.

@davidchisnall davidchisnall merged commit 9675dde into CHERIoT-Platform:main Jul 29, 2024
@PhilDay-CT PhilDay-CT deleted the config_broker_v2 branch November 15, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants