Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more examples of temporal safety #279

Merged
merged 5 commits into from
Aug 2, 2024

Conversation

PhilDay-CT
Copy link
Contributor

Following the recent thread with Murali on sub objects I though it would be useful to add some more use cases to the temporal_safety example to illustrate sub objects and also claims

Copy link
Contributor

@nwf-msr nwf-msr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This looks great and really helps fill in some gaps in our documentation. Mostly comments on the prose; the code itself looks fine.

examples/04.temporal_safety/README.md Outdated Show resolved Hide resolved
examples/04.temporal_safety/README.md Outdated Show resolved Hide resolved
examples/04.temporal_safety/README.md Outdated Show resolved Hide resolved
In the second use case a claim is made on the sub object, which counts against the quota but now means that the sub object remains valid even if the enclosing allocation is freed.
Both the sub object and the enclosing allocation become invalid when the claim is releases.

The third use case shows the difference between a claim and a fast claim.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might be good motivation to finally rename "fast" claims, perhaps before landing an updated version of this PR? @davidchisnall?

examples/04.temporal_safety/README.md Outdated Show resolved Hide resolved
examples/04.temporal_safety/README.md Outdated Show resolved Hide resolved
examples/04.temporal_safety/README.md Outdated Show resolved Hide resolved
examples/04.temporal_safety/README.md Outdated Show resolved Hide resolved
examples/04.temporal_safety/README.md Outdated Show resolved Hide resolved
examples/04.temporal_safety/allocate.cc Show resolved Hide resolved
@davidchisnall davidchisnall merged commit 64d8460 into CHERIoT-Platform:main Aug 2, 2024
6 checks passed
@davidchisnall
Copy link
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants