-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more examples of temporal safety #279
Add more examples of temporal safety #279
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! This looks great and really helps fill in some gaps in our documentation. Mostly comments on the prose; the code itself looks fine.
In the second use case a claim is made on the sub object, which counts against the quota but now means that the sub object remains valid even if the enclosing allocation is freed. | ||
Both the sub object and the enclosing allocation become invalid when the claim is releases. | ||
|
||
The third use case shows the difference between a claim and a fast claim. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might be good motivation to finally rename "fast" claims, perhaps before landing an updated version of this PR? @davidchisnall?
Co-authored-by: Nathaniel Filardo <[email protected]>
Thanks! |
Following the recent thread with Murali on sub objects I though it would be useful to add some more use cases to the temporal_safety example to illustrate sub objects and also claims