Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multiwaiter public header. #419

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix multiwaiter public header. #419

wants to merge 2 commits into from

Conversation

davidchisnall
Copy link
Collaborator

It had a load of left-over things in it from when the scheduler knew about event groups.

It had a load of left-over things in it from when the scheduler knew
about event groups.
@davidchisnall davidchisnall requested a review from nwf January 14, 2025 17:47
Copy link
Member

@nwf nwf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the test caught up, it LGTM. Please squash, not rebase, merge for ease of any future bisections.

@nwf nwf self-requested a review January 14, 2025 21:01
@nwf
Copy link
Member

nwf commented Jan 14, 2025

(There's a bit of cruft, like

unsigned flags : 6 = 0;
and the fact that ::readyEvents is used as a 24-bit boolean, that could also be cleaned up, or left in case we ever wanted something like it again. I think it's not enough cruft that removing it would save bytes in an EventWaiter object?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants